Re: [PATCH] swsusp: misc cleanups [4/4]

From: Pavel Machek
Date: Sat Apr 23 2005 - 17:16:14 EST


Hi!

> The following patch makes some comments and printk()s in swsusp.c up to date.
> In particular it adds the string "swsusp" before every message that is printed by
> the code in swsusp.c.

I don't like this one. Adding swsusp everywhere just clutters the
screen, most of it should be clear from context.

> @@ -1226,9 +1222,6 @@ static int check_sig(void)
>
> /**
> * data_read - Read image pages from swap.
> - *
> - * You do not need to check for overlaps, check_pagedir()
> - * already did that.
> */
>
> static int data_read(struct pbe *pblist)

Why is this comment no longer valid?
Pavel
--
Boycott Kodak -- for their patent abuse against Java.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/