Re: [RFC] non-resident page management

From: Rik van Riel
Date: Sat Apr 23 2005 - 06:33:21 EST


On Sat, 23 Apr 2005, Pekka Enberg wrote:
> On 4/23/05, Rik van Riel <riel@xxxxxxxxxx> wrote:
> > Note that this code could use an actual hash function.
>
> How about this? It computes hash for the two longs and combines them by
> addition and multiplication as suggested by [Bloch01].

I've thought about it, but ...

> @@ -23,7 +23,7 @@
> #error Define GOLDEN_RATIO_PRIME for your wordsize.
> #endif

... include/linux/hash.c appears to only work right for
32 bit words, not 64 bit ones ...

--
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/