Re: [2.6 patch] correct the DEBUG_BUGVERBOSE question dependency

From: Adrian Bunk
Date: Fri Apr 22 2005 - 20:21:56 EST


On Sat, Apr 23, 2005 at 03:05:17AM +0200, Roman Zippel wrote:
> Hi,
>
> On Sat, 23 Apr 2005, Adrian Bunk wrote:
>
> > Currently, DEBUG_BUGVERBOSE, is automatically set to "y" if
> > DEBUG_KERNEL=n and EMBEDDED=y which doesn't make much sense.
> >
> > Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
> >
> > --- linux-2.6.12-rc2-mm3-full/lib/Kconfig.debug.old 2005-04-22 03:03:27.000000000 +0200
> > +++ linux-2.6.12-rc2-mm3-full/lib/Kconfig.debug 2005-04-22 03:04:00.000000000 +0200
> > @@ -125,9 +125,9 @@
> > This options enables addition error checking for high memory systems.
> > Disable for production systems.
> >
> > config DEBUG_BUGVERBOSE
> > - bool "Verbose BUG() reporting (adds 70K)" if DEBUG_KERNEL && EMBEDDED
> > + bool "Verbose BUG() reporting (adds 70K)" if EMBEDDED
> > depends on BUG
> > depends on ARM || ARM26 || M32R || M68K || SPARC32 || SPARC64 || (X86 && !X86_64) || FRV
> > default !EMBEDDED
> > help
>
> 1. you just messed up the menu structure.
> 2. the default is "!EMBEDDED", so it should become "n"?!


Ups, thanks for the correction.

I didn't see this, and this makes my patch completely pointless.


> bye, Roman

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/