Re: [PATCH 2.6.12-rc2] aoe [5/6]: add firmware version to info insysfs

From: Ed L Cashin
Date: Wed Apr 20 2005 - 14:17:55 EST


"Randy.Dunlap" <rddunlap@xxxxxxxx> writes:

...
> so something like 'firmware-version' would be appreciated
> (for the sysfs filename).

Fair enough. This patch follows and depends on the fifth patch of the
six.


use a more explicit filename for sysfs firmware version info

Signed-off-by: Ed L. Cashin <ecashin@xxxxxxxxxx>

diff -urNp a-exp/linux/drivers/block/aoe/aoeblk.c b-exp/linux/drivers/block/aoe/aoeblk.c
--- a-exp/linux/drivers/block/aoe/aoeblk.c 2005-04-20 15:09:13.000000000 -0400
+++ b-exp/linux/drivers/block/aoe/aoeblk.c 2005-04-20 15:09:13.000000000 -0400
@@ -58,7 +58,7 @@ static struct disk_attribute disk_attr_n
.show = aoedisk_show_netif
};
static struct disk_attribute disk_attr_fwver = {
- .attr = {.name = "fwver", .mode = S_IRUGO },
+ .attr = {.name = "firmware-version", .mode = S_IRUGO },
.show = aoedisk_show_fwver
};

@@ -76,7 +76,7 @@ aoedisk_rm_sysfs(struct aoedev *d)
sysfs_remove_link(&d->gd->kobj, "state");
sysfs_remove_link(&d->gd->kobj, "mac");
sysfs_remove_link(&d->gd->kobj, "netif");
- sysfs_remove_link(&d->gd->kobj, "fwver");
+ sysfs_remove_link(&d->gd->kobj, "firmware-version");
}

static int



--
Ed L Cashin <ecashin@xxxxxxxxxx>