Re: [PATCH] crypto: resource release functions ought to check for NULL (crypto_free_tfm)

From: Herbert Xu
Date: Mon Apr 18 2005 - 06:51:46 EST


On Fri, Apr 15, 2005 at 01:15:58AM +0200, Jesper Juhl wrote:
>
> As far as I'm aware there's a general concensus that functions that are
> responsible for freeing resources should be able to cope with being passed
> a NULL pointer. This makes sense as it removes the need for all callers to

In general I'd only do this when most of the callers are doing the
NULL check. As that seems to be the case here, I agree with your
change. I've applied it to my tree.

Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/