Re: {PATCH] Fix IBM EMAC driver ioctl bug

[Eugene Surovegin]

On Thu, Apr 14, 2005 at 11:20:32AM -0700, Geoff Levand wrote:
> Fix IBM EMAC driver ioctl bug.
> 
> I found IBM EMAC driver bug.
> So mii-tool command print wrong status.
> 
>   # mii-tool
>   eth0: 10 Mbit, half duplex, no link
>   eth1: 10 Mbit, half duplex, no link
> 
> I can get correct status on fixed kernel.
> 
>   # mii-tool
>   eth0: negotiated 100baseTx-FD, link okZZ
>   eth1: negotiated 100baseTx-FD, link ok
> 

There is a problem with this patch. I'm aware of this problem for 
quite some time, but chose to keep the current code.

This IOCTL implementation has been here for many years in all 
revisions of the driver, so I think we should keep it as is, because 
some software could rely on it, and your change will break it. 

And all new code should use ethtool anyway :).

-- 
Eugene


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/