Re: [PATCH] sched: fix never executed code due to expressionalways false

From: Nick Piggin
Date: Thu Apr 14 2005 - 22:26:52 EST


On Fri, 2005-04-15 at 12:59 +1000, Herbert Xu wrote:
> Jesper Juhl <juhl-lkml@xxxxxx> wrote:
> >
> > - if (unlikely((long long)now - prev->timestamp < 0))
> > + if (unlikely(((long long)now - (long long)prev->timestamp) < 0))
>
> You can write this as
>
> (long long)(now - prev->timestamp)
>

True. Combined that with Matt's suggestion, and we probably have
the cleanest solution. Thanks.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/