Re: [PATCH] create a kstrdup library function

From: Paulo Marques
Date: Wed Apr 13 2005 - 06:27:07 EST


Paulo Marques wrote:
Hi,

This patch creates a new kstrdup library function and changes the "local" implementations in several places to use this function.

Arkadiusz Miskiewicz reported that this breaks compilation under PPC.

Apparently, PPC builds a bootloader that links against lib.a but doesn't expect any dependencies on slab. Since kstrdup calls kmalloc, this breaks compilation.

I can fix this by moving kstrdup into slab.c. This way this is treated as an "allocation" function instead of a string function, so it makes some sense to do this.

Andrew, do you prefer an incremental patch against the current tree, or a single clean patch against the current tree with all the current kstrdup patches taken out?

--
Paulo Marques - www.grupopie.com

All that is necessary for the triumph of evil is that good men do nothing.
Edmund Burke (1729 - 1797)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/