Re: [patch 6/9] blk: unplug later

From: Nick Piggin
Date: Tue Apr 12 2005 - 20:41:44 EST


Andrew Morton wrote:
Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote:

get_request_wait needn't unplug the device immediately.


Probably. But what if the get_request(q, rw, GFP_NOIO); did
some sleeping?


It can't sleep unless it returns the request, because it
is using mempool allocs. So any time it returns NULL, it
hasn't slept.

But Jens would have a better idea of the correct behaviour.
Jens, what do you think?

--
SUSE Labs, Novell Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/