RE: [patch] new fifo I/O elevator that really does nothing at all

[Chen, Kenneth W]

Chen, Kenneth W wrote on Tuesday, April 05, 2005 5:13 PM
> Jens Axboe wrote on Tuesday, April 05, 2005 7:54 AM
> > On Tue, Mar 29 2005, Chen, Kenneth W wrote:
> > > Jens Axboe wrote on Tuesday, March 29, 2005 12:04 PM
> > > > No such promise was ever made, noop just means it does 'basically
> > > > nothing'. It never meant FIFO in anyway, we cannot break the semantics
> > > > of block layer commands just for the hell of it.
> > >
> > > Acknowledged and understood, will try your patch shortly.
> >
> > Did you test it?
>
> Experiment is in the queue, should have a result in a day or two.


Jens, your patch works!  We are seeing a little bit increase in indirect
branch calls with your patch where our patch tries to remove elevator_merge_fn()
completely.  But the difference is all within noise range.

If there is no other issues (I don't see any), we would like to see this patch
merged upstream.  Thanks.

- Ken


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/