Re: [PATCH encrypted swsusp 1/3] core functionality

[Andreas Steinmetz]

Pavel Machek wrote:
> Hi!
> 
> 
>>The following patch adds the core functionality for the encrypted
>>suspend image.
> 
> 
> +#ifdef CONFIG_SWSUSP_ENCRYPT
> +static struct crypto_tfm *crypto_init(int mode)
> +{
> +       struct crypto_tfm *tfm;
> +       int len;
> +
> +       tfm = crypto_alloc_tfm(CIPHER, CRYPTO_TFM_MODE_CBC);
> +       if(!tfm) {
>           ~ please put space between if and (
> 
> +               printk(KERN_ERR "swsusp: no tfm, suspend not
> possible\n");
> +               return NULL;
> +       }
> +
> +       if(sizeof(key) < crypto_tfm_alg_min_keysize(tfm)) {
> 
> same here.
> 
> Was it really neccessary to include "union u"? I don't like its name,
> and perhaps few casts are better than this. If not, it probably should
> go in separate patch, and ASAP.

I'll revert this and use few casts.

-- 
Andreas Steinmetz                       SPAMmers use robotrap@xxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/