Re: [PATCH encrypted swsusp 1/3] core functionality

[Pavel Machek]

Hi!

> The following patch adds the core functionality for the encrypted
> suspend image.

[Please inline patches, it makes it easier to comment on them.]

You seem to reuse same key/iv for all the blocks. I'm no crypto
expert, but I think that is seriously wrong... You probably should use
block number as a IV or something like that.

Does it slow down swsusp in measurable way, or is it just lost in the
noise?
								Pavel
-- 
Boycott Kodak -- for their patent abuse against Java.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/