Re: [patch] Real-Time Preemption, -RT-2.6.12-rc2-V0.7.44-00

From: Steven Rostedt
Date: Sun Apr 10 2005 - 12:42:43 EST


On Sun, 2005-04-10 at 19:27 +0200, Ingo Molnar wrote:
> * K.R. Foley <kr@xxxxxxxxxx> wrote:
>
> > Ingo,
> >
> > It would seem that in the latest patch RT-V0.7.45-00 we have reverted
> > back to removing the define of jbd_debug which the attached patch
> > (against one of the 2.6.11 versions) fixed.
>
> > +#define jbd_debug(f, a...) /**/
>
> oops, indeed. '/**/' happens to be my private marker for 'debug code',
> which the release scripts automatically strip from the files ...
>
> i've uploaded -45-01 with the fix.
>

Would there be any harm with changing that to

#define jbd_debug(f, a...) do {} while(0)

The compiler would strip it anyway, and you wouldn't have to worry about
your scripts removing the macro.

-- Steve


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/