Re: [PATCH] pm_message_t corrections still missing from 2.6.12-rc2

From: Pavel Machek
Date: Fri Apr 08 2005 - 07:34:08 EST


Hi!

> Here, for your consideration, are fixups I still have in my tree after
> updating to rc2.
>
> (USB & Framebuffer lists copied because a reasonable number apply
> there).
>
> Regards,
>
> Nigel
>
> diff -ruNp 840-combined-pm_message_t-patch.patch-old/drivers/base/power/resume.c 840-combined-pm_message_t-patch.patch-new/drivers/base/power/resume.c
> --- 840-combined-pm_message_t-patch.patch-old/drivers/base/power/resume.c 2004-12-10 14:26:51.000000000 +1100
> +++ 840-combined-pm_message_t-patch.patch-new/drivers/base/power/resume.c 2005-04-08 13:41:41.000000000 +1000
> @@ -41,7 +41,7 @@ void dpm_resume(void)
> list_add_tail(entry, &dpm_active);
>
> up(&dpm_list_sem);
> - if (!dev->power.prev_state)
> + if (!dev->power.prev_state.event)
> resume_device(dev);
> down(&dpm_list_sem);
> put_device(dev);

We do not want these to go anywhere for now. These depend on switching
pm_message_t to struct, and that's 2.6.13 material.

Except that, there are some good fixes (u32->pm_message_t), but they
should be in -mm kernel already.

...except USB. I'm talking with David Brownell about those.

Pavel
--
Boycott Kodak -- for their patent abuse against Java.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/