Re: [patch] use cheaper elv_queue_empty when unplug a device

From: Jens Axboe
Date: Fri Apr 08 2005 - 05:04:18 EST


On Fri, Apr 08 2005, Nick Piggin wrote:
> Jens Axboe wrote:
> >On Wed, Mar 30 2005, Nick Piggin wrote:
>
> >>So Kenneth if you could look into this one as well, to see if
> >>it is worthwhile, that would be great.
> >
> >
> >For that to work, you have to change the get_io_context() allocation to
> >be GFP_ATOMIC.
> >
>
> Yes of course, thanks for picking that up.
>
> I guess this isn't a problem, as io contexts should be allocated
> comparatively rarely. It would be possible to move it out of the
> lock though if we really want to.

Lets just keep it inside the lock, for the fast case it should just be
an increment of the already existing io context.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/