Re: [PATCH] Use proper seq_file api for /proc/scsi/scsi

From: Arjan van de Ven
Date: Fri Apr 08 2005 - 03:10:57 EST


On Fri, 2005-04-08 at 08:56 +0100, Christoph Hellwig wrote:
> On Fri, Apr 08, 2005 at 12:23:46AM -0700, Jeremy Higdon wrote:
> > > It works for those setups that already worked with 2.4.x, aka only a few
> > > luns.
> >
> > Even if it's deprecated, wouldn't it be good to fix it as long as
> > it's there, unless it hurts something else? Or at least fix the
> > out of memory error, even if it doesn't display all the luns?
>
> What other error would you return? I don't particularly care what exact
> error code to return, but putting in Hannes patch would be a bad idea because
> it
>
> a) poke deep into driver model internals, and we absolutely want to avoid
> that
> b) sets a bad precedence that we'll continue adding features to deprecated
> interface and thus encurage people to contiue using it. Note that
> /proc/scsi/* has been deprecated since mid-2.5.x.


so how about starting to remove it?
eg give it its final resting date, start defaulting the config option to
"n" and such...


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/