Re: [PATCH 1/6] freepgt: free_pgtables use vma list

From: Hugh Dickins
Date: Wed Mar 30 2005 - 07:25:31 EST


On Wed, 30 Mar 2005, David Howells wrote:
> Hugh Dickins <hugh@xxxxxxxxxxx> wrote:
> > On Fri, 25 Mar 2005, David S. Miller wrote:
> >
> > [ of flush_tlb_pgtables ]
>
> > > Let's make it so that the flush can be queued up
> > > at pmd_clear() time, as that's what we really want.
> > >
> > > Something like:
> > >
> > > pmd_clear(mm, vaddr, pmdp);
> > >
> > > I'll try to play with something like this later.
> >
> > Depends really on what DavidH wants there, not clear to me.
> > I suspect Ian can live without his printk!
>
> I could do the zapping in pmd_clear() instead, I suppose. It's just that it
> only needs to be done once when tearing down the page tables; not for every
> PMD.

Sounds like we should leave flush_tlb_pgtables as it is
(apart from the issue in its frv implementation that you noticed).

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/