Re: [PATCH] fixup newly added jsm driver

From: Christoph Hellwig
Date: Wed Mar 30 2005 - 01:44:13 EST


On Tue, Mar 29, 2005 at 01:47:34PM -0800, Andrew Morton wrote:
> Christoph Hellwig <hch@xxxxxx> wrote:
> >
> > One more prematurely added drivers..
>
> This driver was first sent out for review a month ago, was upissued twice
> and generated over seventy linux-kernel emails including some from Russell
> and some from Greg. It was by no means a "premature" addition.
>
> One could say that it was inadequately reviewed, but how is one to
> determine that? If the thing has been under discussion for a month and the
> submitter says "I've addressed all comments" then it's going to get merged.

I don't think the submitter should say all issues have been addressed
but that should come from a sufficiently trusted reviewer.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/