Re: [PATCH] ppc32: CPM2 PIC cleanup

[Eugene Surovegin]

On Tue, Mar 29, 2005 at 10:42:29AM -0600, Kumar Gala wrote:
> Andrew,
> 
> Cleaned up the CPM2 interrupt controller code:
> * Added the ability to offset the IRQs
> * Refactored common PIC init code out of platform files
> * Fixed IRQ offsets on MPC85xx so it can handle properly handled multiple 
> interrupt controllers (i8259, CPM2 PIC, and OpenPIC)
> 
> Signed-off-by: Jason McMullan <jason.mcmullan@xxxxxxxxxxx>
> Signed-off-by: Kumar Gala <kumar.gala@xxxxxxxxxxxxx>
> 

[snip]

Guys, while you are at it, could we renumber irq_to_siubit[] array in 
cpm2_pic.c so we can get rid of "1 << (31 - bit)" expressions and 
simply use "1 << bit"? I know, it's a minor thing, but you are 
cleaning this stuff anyway, why not make it super clean :).

--
Eugene
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/