[2.6 patch] drivers/scsi/sg.c: fix check after use

From: Adrian Bunk
Date: Sun Mar 27 2005 - 15:50:53 EST


This patch fixes a check after use found by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

--- linux-2.6.12-rc1-mm1-full/drivers/scsi/sg.c.old 2005-03-23 04:57:20.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/scsi/sg.c 2005-03-23 04:57:50.000000000 +0100
@@ -1208,11 +1208,14 @@
sg_mmap(struct file *filp, struct vm_area_struct *vma)
{
Sg_fd *sfp;
- unsigned long req_sz = vma->vm_end - vma->vm_start;
+ unsigned long req_sz;
Sg_scatter_hold *rsv_schp;

if ((!filp) || (!vma) || (!(sfp = (Sg_fd *) filp->private_data)))
return -ENXIO;
+
+ req_sz = vma->vm_end - vma->vm_start;
+
SCSI_LOG_TIMEOUT(3, printk("sg_mmap starting, vm_start=%p, len=%d\n",
(void *) vma->vm_start, (int) req_sz));
if (vma->vm_pgoff)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/