Re: [patch] xfrm_policy destructor fix

[David S. Miller]

On Fri, 25 Mar 2005 15:34:41 +0100
Ingo Molnar <mingo@xxxxxxx> wrote:

> the patch below fixes a bug that i encountered while running a 
> PREEMPT_RT kernel, but i believe it should be fixed in the generic 
> kernel too. xfrm_policy_kill() queues a destroyed policy structure to 
> the GC list, and unlocks the policy->lock spinlock _after_ that point.  
> This created a scenario where GC processing got to the new structure 
> first, and kfree()d it - then the write_unlock_bh() was done on the 
> already kfreed structure. There is no guarantee that GC processing will 
> be done after policy->lock has been dropped and softirq processing has 
> been enabled.
> 
> Signed-off-by: Ingo Molnar <mingo@xxxxxxx>

Good catch Ingo, patch applied.  Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/