Re: memory leak in net/sched/ipt.c?

From: jamal
Date: Wed Mar 23 2005 - 07:41:59 EST


On Wed, 2005-03-23 at 06:30, Herbert Xu wrote:
> Yichen Xie <yxie@xxxxxxxxxxxxxxx> wrote:
> > Is the memory block allocated on line 315 leaked every time tcp_ipt_dump
> > is called?
>
> It seems to be. This patch should free it.
>
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
>
> BTW, please report networking bugs to netdev@xxxxxxxxxxxx
>

Thanks for pointing this out - I _know_ its in the kernel list FAQ.
I was sitting beside R Gooch when he added "thou shalt post to netdev".
And of course i am gonna bitch about it every time someone doesnt
post to netdev;->

Just a small correction to patchlet:
The second kfree should check for existence of t.

cheers,
jamal

> Thanks,

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/