Re: [PATCH] Jazzsonic driver updates

[Finn Thain]

On Wed, 23 Mar 2005, Ralf Baechle wrote:

> On Tue, Mar 22, 2005 at 06:13:17PM +0100, Geert Uytterhoeven wrote:
> 
> > On Fri, 28 Jan 2005, Linux Kernel Mailing List wrote:
> > > ChangeSet 1.1986, 2005/01/28 00:12:28-05:00, ralf@xxxxxxxxxxxxxx
> > > 
> > > 	[PATCH] Jazzsonic driver updates
> > > 	
> > > 	 o Resurrect the Jazz SONIC driver after years of it not having been tested
> > > 	 o Convert from Space.c initialization to module_init / platform device.
> > > 	
> > > 	Signed-off-by: Jeff Garzik <jgarzik@xxxxxxxxx>
> > 
> > > --- a/drivers/net/sonic.c	2005-03-06 18:10:39 -08:00
> > > +++ b/drivers/net/sonic.c	2005-03-06 18:10:39 -08:00
> > > @@ -116,7 +116,7 @@
> > >  	/*
> > >  	 * Map the packet data into the logical DMA address space
> > >  	 */
> > > -	if ((laddr = vdma_alloc(PHYSADDR(skb->data), skb->len)) == ~0UL) {
> > > +	if ((laddr = vdma_alloc(CPHYSADDR(skb->data), skb->len)) == ~0UL) {
> >                                 ^^^^^^^^^
> > This part broke compilation for Mac/m68k.
> > 
> > >  		printk("%s: no VDMA entry for transmit available.\n",
> > >  		       dev->name);
> > >  		dev_kfree_skb(skb);
> 
> Oh funny.  vdma_alloc() was created 10 years ago as an internal API for
> the Jazz machines.  Didn't realize m68k had cloned it :-)

m68k doesn't clone it. This is from macsonic.c,

#define vdma_alloc(foo, bar) ((u32)foo)

> If anything it seems this should be converted to the modern DMA API.

Sure, but until that happens, it would be nice if the upstream kernel had 
the MIPS repo versions of sonic.c, sonic.h and jazzsonic.c. That way it 
might be possible for me to put together a patch for macsonic that both 
archs are happy with.

It doesn't require a new DMA API to fix all the built-in ethernet ports on 
68k Macs.

-f

>   Ralf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/