Re: [2.6 patch] drivers/cdrom/gscd.c: kill dead code

[Andreas Schwab]

Adrian Bunk <bunk@xxxxxxxxx> writes:

> This patch removes some obviously dead code found by the Coverity 
> checker.
>
> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
>
> --- linux-2.6.12-rc1-mm1-full/drivers/cdrom/gscd.c.old	2005-03-22 20:58:54.000000000 +0100
> +++ linux-2.6.12-rc1-mm1-full/drivers/cdrom/gscd.c	2005-03-22 20:59:46.000000000 +0100
> @@ -694,12 +694,8 @@
>  		do {
>  			result = wait_drv_ready();
>  		} while (result != 6 || result == 0x0E);
>  
> -		if (result != 6) {
> -			cmd_end();
> -			return;
> -		}

I'd rather guess that (result != 6 || result == 0x0E) is borken, since
it's equivalent to (result != 6).

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@xxxxxxx
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/