[RFC: 2.6 patch] drivers/net/wireless/airo.c: correct a wrong

From: Adrian Bunk
Date: Tue Mar 22 2005 - 17:30:06 EST


if
Reply-To:

The Coverity checker correctly noted that this condition can't ever be
fulfilled.

Can someone understanding this code check whether my guess what this
should have been was right?

Or should the if get completely dropped?

Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

--- linux-2.6.12-rc1-mm1-full/drivers/net/wireless/airo.c.old 2005-03-22 21:41:37.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/net/wireless/airo.c 2005-03-22 21:42:01.000000000 +0100
@@ -3440,9 +3440,6 @@
/* Make sure we got something */
if (rxd.rdy && rxd.valid == 0) {
len = rxd.len + 12;
- if (len < 12 && len > 2048)
- goto badrx;
-
skb = dev_alloc_skb(len);
if (!skb) {
ai->stats.rx_dropped++;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/