Re: [patch 1/4 with proper signed-off]security/selinux/ss/policydb.c: fix sparse warnings

[Stephen Smalley]

On Tue, 2005-03-22 at 10:19 -0500, Stephen Smalley wrote:
> You didn't remove the loop that already converted these values to little

s/ to / from /

> endian already (no that isn't the same as the earlier loop that you did
> remove), so now you are converting them twice.  And why is this new code
> better even if you fix this omission?  

Note btw that you would also need to modify usage of buf[0] and buf[1]
if you do remove that loop.  But I'm still not clear on the benefit of
the change (silencing warnings generated by a checker doesn't count
unless they point to a real bug).

-- 
Stephen Smalley <sds@xxxxxxxxxxxxx>
National Security Agency

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/