Re: [rfc/rft] Fujitsu B-Series Lifebook PS/2 TouchScreen driver

From: Dmitry Torokhov
Date: Tue Mar 22 2005 - 09:22:00 EST


On Tue, 22 Mar 2005 13:01:14 +0300, Andrey Panin <pazke@xxxxxxxxx> wrote:
> On 081, 03 22, 2005 at 02:13:45AM -0500, Dmitry Torokhov wrote:
> > On Monday 21 March 2005 10:31, Kenan Esau wrote:
> > > Am Montag, den 21.03.2005, 09:52 -0500 schrieb Dmitry Torokhov:
> > > >
> > > > There are couple of things that I an concerned with:
> > > >
> > > > 1. I don't like that it overrides meaning of max_proto parameter to be
> > > > exactly the protocol specified.
> > >
> > > Yeah -- I agree. I also don't like that double-meaning. That was the
> > > reason why I originally proposed the use of a new parameter...
> > >
> >
> > Ok, I have some patches to lifebook that I would like to included (if
> > they work):
> >
> > 1. lifebook-dmi-x86-only - do not compile in DMI detection on anything
> > but x86.
>
> On !x86 machines DMI functions will be optimized away and so you'll save only
> few bytes in .init.data section. IMHO it's not worth additional ugly #ifdef's.
>

It is not in .init.data, it is not discarded... Still probably OK to
keep. Not quite sure.

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/