Re: [patch] Real-Time Preemption, -RT-2.6.12-rc1-V0.7.41-01

[Ingo Molnar]

regarding this code:

void synchronize_kernel(void)
{
        long oldbatch;

        smp_mb();
        oldbatch = rcu_ctrlblk.batch;
        schedule_timeout(HZ/GRACE_PERIODS_PER_SEC);

what is the intent of that schedule_timeout() - a fixed-period delay? Is
that acceptable? In any case, it wont do what you think it does, you
should use mdelay(), or do current->state = TASK_UNINTERRUPTIBLE -
otherwise the call will just return when we are in TASK_RUNNING.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/