Re: [PATCH][2/2] SquashFS

[David Lang]

Josh,
  I agree with you about the 4G limit, but I think Pavel has a point about 
the need to be endian clean.

David Lang

On Mon, 21 Mar 2005, Josh Boyer wrote:

> Date: Mon, 21 Mar 2005 20:41:05 -0600
> From: Josh Boyer <jdub@xxxxxxxxxx>
> To: Pavel Machek <pavel@xxxxxxx>
> Cc: Phillip Lougher <phillip@xxxxxxxxxxxxxxxxxxx>,
>     Paulo Marques <pmarques@xxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>,
>     greg@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH][2/2] SquashFS
>
> On Mon, 2005-03-21 at 23:49 +0100, Pavel Machek wrote:
> > Hi!
> >
> > > > Perhaps squashfs is good enough improvement over cramfs... But I'd
> > > > like those 4Gb limits to go away.
> > >
> > > So would I.  But it is a totally groundless reason to refuse kernel
> > > submission because of that, Squashfs users are quite happily using it
> > > with such a "terrible" limitation.  I'm asking for Squashfs to be put in
> > > the kernel _now_ because users are asking me to do it _now_.  If it
> >
> > Putting it into kernel because users want it is... not a good
> > reason. You should put it there if it is right thing to do. I believe
> > you should address those endianness issues and drop V1 support. If
> > breaking 4GB limit does not involve on-disk format change, it may be
> > okay to merge. After code is merged, doing format changes will be
> > hard...
>
> No, it's not.  If the on disk format needs to change, it's usually a
> sign that the code has changed enough to warrant a version change.  And
> there are examples of that all over the kernel.  Ext3, JFFS2, and
> Reiser4, are just a few.  The SquashFS code is very useful as it is
> today.  There is no reason to delay it's inclusion because it has a 4GiB
> limitation.
>
> And while I agree that something should be included in the kernel for
> the "right" reasons, you still have to listen to users.  In this case,
> those users range from the embedded world to actual distributions.
>
> This is a useful, stable, and _maintained_ filesystem and I'm a bit
> surprised that there is this much resistance to it's inclusion.
>
> josh
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
There are two ways of constructing a software design. One way is to make it so simple that there are obviously no deficiencies. And the other way is to make it so complicated that there are no obvious deficiencies.
 -- C.A.R. Hoare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/