Re: [PATCH 0/5] I8K driver facelift

[Dmitry Torokhov]

On Monday 21 March 2005 17:53, Frank Sorenson wrote:
> Dmitry Torokhov wrote:
> > I have implemented arrays of groups of attributes:
> 
> Works great here.  The i8k-cumulative patch claimed to be malformed, but
> I merged it in just fine by hand.  In arch/i386/kernel/dmi_scan.c, I had
> to EXPORT dmi_get_system_info in order to get the i8k module to load.
> That may have been a mistake on my end (lots of odd patches in my tree
> right now). 

No, I bet I forgot to export it - I have i8k compiled in and would not
notice missing export.
 
> I'm a little curious to see how many people are going to 
> find they need the ignore_dmi flag versus working without it.

I want this driver to be first of all safe for loading on a random box
so it can be enabled by default.

> 
> Everything works great, and it is a big step up from the existing code.
>  I say lets go with it.
>

Yep, I will add missing export and forward it to Andrew - it could use
some time in -mm.

Thank you very much for testing it.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/