[PATCH] arlan: MODULE_PARM_DESC

From: Magnus Damm
Date: Mon Mar 21 2005 - 08:27:57 EST


Some module parameter descriptions should only be present when debugging is
enabled, ie when ARLAN_ENTRY_EXIT_DEBUGGING is defined. The patch fixes this
and adds "arlan_entry_and_exit_debug" that was missing.

Error detected with section2text.rb, see autoparam patch.

Signed-off-by: Magnus Damm <damm@xxxxxxxxxxxxx>

--- linux-2.6.12-rc1/drivers/net/wireless/arlan-main.c 2005-03-20 18:09:15.000000000 +0100
+++ linux-2.6.12-rc1-autoparam/drivers/net/wireless/arlan-main.c 2005-03-21 13:39:53.288470352 +0100
@@ -33,8 +33,6 @@

#ifdef ARLAN_DEBUGGING

-static int arlan_entry_debug;
-static int arlan_exit_debug;
static int testMemory = testMemoryUNKNOWN;
static int irq = irqUNKNOWN;
static int txScrambled = 1;
@@ -43,8 +41,6 @@
module_param(irq, int, 0);
module_param(mdebug, int, 0);
module_param(testMemory, int, 0);
-module_param(arlan_entry_debug, int, 0);
-module_param(arlan_exit_debug, int, 0);
module_param(txScrambled, int, 0);
MODULE_PARM_DESC(irq, "(unused)");
MODULE_PARM_DESC(testMemory, "(unused)");
@@ -67,13 +63,15 @@
MODULE_PARM_DESC(arlan_debug, "Arlan debug enable (0-1)");
MODULE_PARM_DESC(retries, "Arlan maximum packet retransmisions");
#ifdef ARLAN_ENTRY_EXIT_DEBUGGING
+static int arlan_entry_debug;
+static int arlan_exit_debug;
+static int arlan_entry_and_exit_debug;
+module_param(arlan_entry_debug, int, 0);
+module_param(arlan_exit_debug, int, 0);
+module_param(arlan_entry_and_exit_debug, int, 0);
MODULE_PARM_DESC(arlan_entry_debug, "Arlan driver function entry debugging");
MODULE_PARM_DESC(arlan_exit_debug, "Arlan driver function exit debugging");
MODULE_PARM_DESC(arlan_entry_and_exit_debug, "Arlan driver function entry and exit debugging");
-#else
-MODULE_PARM_DESC(arlan_entry_debug, "(ignored)");
-MODULE_PARM_DESC(arlan_exit_debug, "(ignored)");
-MODULE_PARM_DESC(arlan_entry_and_exit_debug, "(ignored)");
#endif

struct arlan_conf_stru arlan_conf[MAX_ARLANS];
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/