Re: [PATCH] Xen/i386 cleanups - AGP bus/phys cleanups

From: Rik van Riel
Date: Thu Mar 17 2005 - 23:24:27 EST


On Fri, 18 Mar 2005, Paul Mackerras wrote:

> However, the idea of having phys_to_agp/agp_to_phys (or
> virt_to_agp/agp_to_virt) sounds like it wouldn't be too much effort, if
> it would help Xen.

It would be absolutely trivial. On most architectures you would have:

#define virt_to_agp virt_to_phys
#define agp_to_virt phys_to_virt

On Xen you would have:

#define virt_to_agp virt_to_bus
#define agp_to_virt bus_to_virt

Or, more likely, defined to arbitrary_machine_to_phys
or whatever it was called ;)

--
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/