Re: [PATCH] Xen/i386 cleanups - AGP bus/phys cleanups

From: Jesse Barnes
Date: Wed Mar 16 2005 - 13:02:15 EST


On Wednesday, March 16, 2005 3:48 am, Keir Fraser wrote:
> This patch cleans up AGP driver treatment of bus/device memory. Every
> use of virt_to_phys/phys_to_virt should properly be converting between
> virtual and bus addresses: this distinction really matters for the Xen
> hypervisor.
>
> Furthermore, when allocating the GATT, it is necessary to use
> dma_alloc_coherent rather than get_free_pages. Again, not a
> distinction that matters for i386, but very important for Xen and
> possibly for other architectures too.
>
> Signed-off-by: Keir Fraser <keir@xxxxxxxxxxxxx>

Ugg, if we're messing with these drivers we may as well fix them properly
rather than adding in more uses of the broken virt_to_bus interface...

Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/