Re: swsusp_restore crap

[Benjamin Herrenschmidt]

> It breaks compilation on i386 either, because nr_copy_pages_check
> is static in swsusp.c.  May I propose the following patch instead (tested on
> x86-64 and i386)?
> 
> Greets,
> Rafael
> 
> Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
> 
> diff -Nrup linux-2.6.11-bk10-a/arch/i386/power/cpu.c linux-2.6.11-bk10-b/arch/i386/power/cpu.c
> --- linux-2.6.11-bk10-a/arch/i386/power/cpu.c	2005-03-15 09:20:53.000000000 +0100
> +++ linux-2.6.11-bk10-b/arch/i386/power/cpu.c	2005-03-15 12:16:57.000000000 +0100
> @@ -147,6 +147,15 @@ void restore_processor_state(void)
>  	__restore_processor_state(&saved_context);
>  }
>  
> +asmlinkage int __swsusp_flush_tlb(void)
> +{
> +	swsusp_restore_check();
> +

Do we really need that check there ? Can't it be moved elsewhere ?

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/