Re: [PATCH RFC]: DEBUG for PCI IO & MEM allocation

From: Andrew Morton
Date: Tue Mar 15 2005 - 00:29:27 EST


Prarit Bhargava <prarit@xxxxxxx> wrote:
>
> I propose the following patch to add a compile time DEBUG option to
> kernel/resource.c that would help in analyzing problems in this area.
> It's a few simple lines of output in __request_resource,
> __release_resource, __request_region, and __release_region .
>

A sane enough requirement.

>
> + DEBUGP("%s: resource request at 0x%lx-0x%lx\n", __FUNCTION__, new->start, new->end);

Shouldn't this also be printing the ->name of the new resource?

A lot of the statements which you're adding will look screwy in an 80-col
xterm. Please wrap 'em.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/