Re: 2.6.11-mm3: saa7134-core.c compile error

From: Andrew Morton
Date: Mon Mar 14 2005 - 23:45:07 EST


Adrian Bunk <bunk@xxxxxxxxx> wrote:
>
> On Sat, Mar 12, 2005 at 03:42:22AM -0800, Andrew Morton wrote:
> >...
> > Changes since 2.6.11-mm2:
> >...
> > +saa7134-update.patch
> >...
> > v4l updates
> >...
>
> This doesn't compile with CONFIG_MODULES=n:
>
> <-- snip -->
>
> ...
> CC drivers/media/video/saa7134/saa7134-core.o
> drivers/media/video/saa7134/saa7134-core.c: In function `saa7134_fini':
> drivers/media/video/saa7134/saa7134-core.c:1215: error: `pending_registered' undeclared (first use in this function)

Like this, I guess:

--- 25/drivers/media/video/saa7134/saa7134-core.c~saa7134-build-fix 2005-03-14 20:37:16.000000000 -0800
+++ 25-akpm/drivers/media/video/saa7134/saa7134-core.c 2005-03-14 20:37:27.000000000 -0800
@@ -1212,8 +1212,10 @@ static int saa7134_init(void)

static void saa7134_fini(void)
{
+#ifdef CONFIG_MODULES
if (pending_registered)
unregister_module_notifier(&pending_notifier);
+#endif
pci_unregister_driver(&saa7134_pci_driver);
}

_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/