Re: [PATCH] buildcheck: reduce DEBUG_INFO noise from reference* scripts

From: Randy.Dunlap
Date: Mon Mar 14 2005 - 16:44:27 EST


Keith Owens wrote:
On Mon, 14 Mar 2005 11:02:09 -0800, "Randy.Dunlap" <rddunlap@xxxxxxxx> wrote:

Reduce noise in 'make buildcheck' that is caused by CONFIG_DEBUG_INFO=y.

Signed-off-by: Randy Dunlap <rddunlap@xxxxxxxx>

diffstat:=
scripts/reference_discarded.pl | 3 +++
scripts/reference_init.pl | 1 +
2 files changed, 4 insertions(+)

diff -Naurp ./scripts/reference_discarded.pl~ref_init_debugs ./scripts/reference_discarded.pl
--- ./scripts/reference_discarded.pl~ref_init_debugs 2005-03-01 23:38:08.000000000 -0800
+++ ./scripts/reference_discarded.pl 2005-03-14 10:38:47.000000000 -0800
@@ -82,6 +82,8 @@ foreach $object (keys(%object)) {
}
if (($line =~ /\.text\.exit$/ ||
$line =~ /\.exit\.text$/ ||
+ $line =~ /\.text\.init$/ ||
+ $line =~ /\.init\.text$/ ||
$line =~ /\.data\.exit$/ ||
$line =~ /\.exit\.data$/ ||
$line =~ /\.exitcall\.exit$/) &&
@@ -96,6 +98,7 @@ foreach $object (keys(%object)) {
$from !~ /\.debug_ranges$/ &&
$from !~ /\.debug_line$/ &&
$from !~ /\.debug_frame$/ &&
+ $from !~ /\.debug_loc$/ &&
$from !~ /\.exitcall\.exit$/ &&
$from !~ /\.eh_frame$/ &&
$from !~ /\.stab$/)) {
diff -Naurp ./scripts/reference_init.pl~ref_init_debugs ./scripts/reference_init.pl
--- ./scripts/reference_init.pl~ref_init_debugs 2005-03-01 23:38:17.000000000 -0800
+++ ./scripts/reference_init.pl 2005-03-14 10:40:19.000000000 -0800
@@ -98,6 +98,7 @@ foreach $object (sort(keys(%object))) {
$from !~ /\.pdr$/ &&
$from !~ /\__param$/ &&
$from !~ /\.altinstructions/ &&
+ $from !~ /\.eh_frame/ &&
$from !~ /\.debug_/)) {
printf("Error: %s %s refers to %s\n", $object, $from, $line);
}



Adding .debug_loc and .eh_frame to the exclude lists is fine. But why
add .text.init and .init.text to the selection list in
reference_discarded.pl? reference_discarded.pl only looks at exit
sections, not init sections. reference_init.pl already handles the
init sections.

Indeed, it's actually much worse with that patch section added. :(
I don't know how I got there.

Sam, can you drop the very first patch section here, or shall I send
a new patch for this?

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/