Re: [PATCH][2.6.11-mm3] perfctr ia32 syscalls on x86-64 fix

From: Andrew Morton
Date: Sun Mar 13 2005 - 01:00:18 EST


Mikael Pettersson <mikpe@xxxxxxxxx> wrote:
>
> The ia32 perfctr syscalls were moved due to addition of ioprio
> syscalls, but the ia32 emulation code in x86-64 wasn't updated.

Ho hum. The perfctr syscall API has changed so many times that whenever
someone adds a syscall I have rejects to fix up in probably ten different
patches.

It would be nice to start folding these patches together a bit to reduce
such problems, but that's rather non-trivial because there is no way to
simply join these patches together which maintains a sensible sequencing.

If we're going to do anything then it's either a major refactoring, or
simply wham the entire feature into a single diff. That diff could then be
split into four patches: core, ppc, x86 and x86_64. We would lose the
layering between ye olde perfctr, the inheritance implementation, the syfs
API, etc. I could live with that.

What do you think?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/