Re: AGP bogosities

From: Dave Jones
Date: Fri Mar 11 2005 - 17:29:38 EST


On Sat, Mar 12, 2005 at 07:18:19AM +0900, OGAWA Hirofumi wrote:
> Linus Torvalds <torvalds@xxxxxxxx> writes:
>
> > Hmm.. We seem to not have any tests for the counts becoming negative, and
> > this would seem to be an easy mistake to make considering that both I and
> > Dave did it.
>
> I stole this from -mm.

I'm fascinated that not a single person picked up on this problem
whilst the agp code sat in -mm. Even if DRI isn't enabled,
every box out there with AGP that uses the generic routines
(which is a majority), should have barfed loudly when it hit
this check during boot. Does no-one read dmesg output any more ?

Maybe OSDL can add an automated test to send diffs of dmesg
between kernels like they do the automated warning announcements 8-)

Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/