Re: [ patch 3/5] drivers/serial/jsm: new serial device driver

[Arjan van de Ven]

On Fri, 2005-03-11 at 10:38 -0500, Wen Xiong wrote:

> +static void neo_set_cts_flow_control(struct jsm_channel *ch)
> +{
> +	u8 ier = readb(&ch->ch_neo_uart->ier);
> +	u8 efr = readb(&ch->ch_neo_uart->efr);
> +
...
> +
> +	writeb(ier, &ch->ch_neo_uart->ier);
> +}


Hi,

have you ever audited this driver for PCI posting errors? On very first
sight it looks like the driver doesn't do this correctly but it might
just be very subtle...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/