Re: [PATCH] realtime-preempt: update inherited priorities on setscheduler

[Ingo Molnar]

* Scott Wood <scott@xxxxxxxxxxxxxx> wrote:

> -	p->prio = effective_prio(p);
> +	/* Don't overwrite an inherited RT priority with the static
> +	   RT priority. */
> +
> +	if (!rt_task(p))
> +		p->prio = effective_prio(p);

are you sure this is needed? The -RT code currently does this:

 static int effective_prio(task_t *p)
 {
         if (rt_task(p))
                 return p->prio;
         return __effective_prio(p);
 }

i.e. if it's an RT task then 'effective priority' is whatever it has
right now. I.e. 'p->prio = effective_prio(p)' will have no effect for RT
tasks. PI would not be working at all if we were overwriting the
inherited priority.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/