Re: [patch 4/5] audit mips fix

From: Ralf Baechle
Date: Thu Mar 10 2005 - 12:26:16 EST


On Fri, Mar 04, 2005 at 01:16:57PM -0800, akpm@xxxxxxxx wrote:

> Signed-off-by: Yoichi Yuasa <yuasa@xxxxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxx>

> @@ -307,7 +308,7 @@ asmlinkage void do_syscall_trace(struct
> {
> if (unlikely(current->audit_context)) {
> if (!entryexit)
> - audit_syscall_entry(current, regs->orig_eax,
> + audit_syscall_entry(current, regs->regs[2],

Wrong. regs[2] can will contain the syscall return value and can be
modified by ptrace also.

Ralf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/