Re: [PATCH 2.6.11] fix: drivers/base/class.c

[Greg KH]

On Thu, Mar 10, 2005 at 03:08:56PM +0300, JustMan wrote:
> fix: drivers/base/class.c

"fix" how?  What are you fixing?

> diff -uNrp linux/drivers/base/class.orig.c  linux/drivers/base/class.c
> --- linux/drivers/base/class.orig.c 2005-03-10 12:19:00.000000000 +0300
> +++ linux/drivers/base/class.c 2005-03-10 13:59:27.000000000 +0300
> @@ -307,12 +307,14 @@ static int class_hotplug(struct kset *ks
>   if (class_dev->dev) {
>    /* add physical device, backing this device  */
>    struct device *dev = class_dev->dev;

Your email client ate all of the tabs, this patch can't be applied :(

> -  char *path = kobject_get_path(&dev->kobj, GFP_KERNEL);
>  
> -  add_hotplug_env_var(envp, num_envp, &i, buffer, buffer_size,
> -        &length, "PHYSDEVPATH=%s", path);
> -  kfree(path);
> +  if(kobject_name(&dev->kobj)) {
> +   char *path = kobject_get_path(&dev->kobj, GFP_KERNEL);
>  
> +   add_hotplug_env_var(envp, num_envp, &i, buffer, buffer_size,
> +        &length, "PHYSDEVPATH=%s", path);
> +   kfree(path);
> +  }

Let me guess, you are using an out-of-tree driver that incorrectly sets
up the kobject and the hotplug userspace code doesn't like the <NULL> in
the strings?

Fix the driver, the kobject should have a name.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/