Re: [patch 1/1] x86-64: forgot asmlinkage on sys_mmap

[Blaisorblade]

On Wednesday 09 March 2005 18:24, Andi Kleen wrote:
> blaisorblade@xxxxxxxx writes:
> > CC: Andi Kleen <ak@xxxxxxx>
> >
> > I think it should be there, please check better.
>
> It doesn't matter. asmlinkage is a nop on x86-64.

Yes, otherwise nothing would work on x86-64 with mmap broken, but for 
cleanness and for the case this change it should be there (otherwise why 
asmlinkage is used in the rest of the file).

And for i386 asmlinkage acquired significance only recently.
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/