RE: [ patch 6/7] drivers/serial/jsm: new serial device driver

[Kilau, Scott]

Hi Wendy, Greg, all,

If IBM intends on our DPA management program to work for the JSM
products,
the ioctls are needed.

DPA support is a requirement for all Digi drivers, so it would
not be possible for me to remove them from my "dgnc" version
of the driver.

For the JSM driver, its up to you whether you feel its needed or not.

However, I would like to mention that the DIGI drivers that currently
reside in the kernel sources *do* reserve that ioctl space,
and is acknowledged by "Documentation/ioctl-number.txt":
> d'     F0-FF   linux/digi1.h

I understand that the list is not a reservation list,
but a current list of potential ioctl conflicts...

But the JSM driver sure doesn't add any new ioctl ranges,
or cause any new conflicts that didn't already exist.

Scott



-----Original Message-----
From: Wen Xiong [mailto:wendyx@xxxxxxxxxx] 
Sent: Wednesday, March 09, 2005 11:32 AM
To: Greg KH
Cc: Kilau, Scott; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [ patch 6/7] drivers/serial/jsm: new serial device driver


Greg KH wrote:

>On Wed, Mar 09, 2005 at 10:50:04AM -0500, Wen Xiong wrote:
>  
>
>>+/* Ioctls needed for dpa operation */
>>+#define DIGI_GETDD	('d'<<8) | 248		/* get driver info
*/
>>+#define DIGI_GETBD	('d'<<8) | 249		/* get board info
*/
>>+#define DIGI_GET_NI_INFO ('d'<<8) | 250		/*
nonintelligent state snfo */
>>    
>>
>
>Hm, new ioctls still?...
>
>And the structures you are attempting to access through these ioctls
are
>incorrect, so if you are still insisting you need them, at least make
>the code work properly :(
>
>thanks,
>
>greg k-h
>
>  
>
Hi Scott,

The above three ioctls are for dpa/managment. If I removed these ioctls,

I have to remove jsm_mgmt.c(patch5.jasmine).
Do you mind I remove jsm_mgmt.c code now? From my side, I  don't think I

need them now.

Maybe we can have a solution in the kernel as Russell and Greg said
later.

Thanks,
wendy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/