Re: Fix suspend/resume problems with b44

[David S. Miller]

On Tue, 8 Mar 2005 10:46:55 +0100
Pavel Machek <pavel@xxxxxx> wrote:

> @@ -1934,6 +1936,9 @@
>  	if (!netif_running(dev))
>  		return 0;
>  
> +	if (request_irq(dev->irq, b44_interrupt, SA_SHIRQ, dev->name, dev))
> +		printk(KERN_ERR PFX "%s: request_irq failed\n", dev->name);
> +

This is a hard error and means that bringup of the chip
will totally fail.  It definitely deserves something harder
than a printk(), but unfortunately ->resume() has no way
to cleanly fail.

-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html