Re: [2.6 patch] mm/swap_state.c: unexport swapper_space

From: Russell King
Date: Tue Mar 08 2005 - 04:11:39 EST


On Sun, Mar 06, 2005 at 10:49:12PM +0000, Christoph Hellwig wrote:
> I disagree. swapper_state is far too much of an internal detail to be
> exported. I argued that way when page_mapping was changed to use it and
> that's why the architectures moved their helpers out of line.
> Looks like the exported unfortunately got added anyway although we settled
> that discussion.

Well, since ARM's usage of page_mapping() is out of line (which is
where it'll now stay) I think Christoph is correct. Maybe this is
something which should be aired on linux-arch for the other arch
maintainers?

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/