Re: [PATCH 1/2] BDI: Provide backing device capability information

From: Miklos Szeredi
Date: Mon Mar 07 2005 - 10:24:01 EST


> The attached patch replaces backing_dev_info::memory_backed with
> capabilitied bitmap. The capabilities available include:

Wouldn't it be better to reverse the meaning of BDI_CAP_ACCOUNT_DIRTY
and BDI_CAP_WRITEBACK_DIRTY (BDI_CAP_NO_ACCOUNT_DIRTY...)? That way
out of tree filesystems that implicitly zero bdi->memory_backed
wouldn't _silently_ break. E.g. fuse does this, though it would not
actually break since it doesn't dirty any pages currently. I have no
idea whether there are other filesystems that are affected.

Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/