Re: [2.6 patch] unexport do_settimeofday

From: Adrian Bunk
Date: Sat Feb 26 2005 - 10:24:02 EST


On Fri, Feb 25, 2005 at 03:20:09PM -0800, Andrew Morton wrote:
> Adrian Bunk <bunk@xxxxxxxxx> wrote:
> >
> > > +#ifdef MODULE
> > > +#define __deprecated_in_modules __deprecated
> > > +#else
> > > +#define __deprecated_in_modules /* OK in non-modular code */
> > > +#endif
> > > +
> > >...
> >
> > Looks good.
> >
> >
> > One more question:
> >
> > You get a false positive if the file containing the symbol is itself a
> > module.
>
> I don't understand what you mean.
>
> You mean that a module is doing an EXPORT_SYMBOL of a symbol which is on
> death row?

Yes.

> If so: err, not sure. I guess we could just live with the warning.
>...

OK.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/