Re: [ckrm-tech] Re: [PATCH] CKRM [7/8] Resource controller for number of tasks per class

[Chandra Seetharaman]

On Thu, Feb 24, 2005 at 08:15:43AM -0800, Dave Hansen wrote:
> On Thu, 2005-02-24 at 01:34 -0800, Gerrit Huizenga wrote:
> > This patch provides a resource controller for limiting the number
> > of tasks per class in CKRM.
> 
> It takes 627 lines of code to count the number of tasks in a class?

It is not just counting the number of tasks. It helps the user to manage
and monitor it, which one can use to do accounting, planning etc.,

But, we get your point. will look into it.
> What does all of that infrastructure buy you, again?
> 
> All of the logic to borrow if you've gone over your limit should be a
> quite repeated theme throughout all of the controllers.  Seems to me
> that at least a larger chunk of that should be in generic code.  

Current controllers we have are very different from each other(because of
the nature of the resource they manage) in the way they handle the shares.
That makes sharing hard.

We do have plan to make one of the function common.
> 
> > +static void numtasks_res_free(void *my_res)
> > +{
> ...
> > +       if (unlikely(atomic_read(&res->cnt_cur_alloc) < 0)) {
> > +               printk(KERN_WARNING "numtasks_res: counter below 0
> > \n");
> > +       }
> > +       if (unlikely(atomic_read(&res->cnt_cur_alloc) > 0 ||
> > +                               atomic_read(&res->cnt_borrowed) > 0)) 
> 
> How often is this called?  Do you really need unlikely()?

not very often. can go.
> 
> -- Dave
> 
> 
> 
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> ckrm-tech mailing list
> https://lists.sourceforge.net/lists/listinfo/ckrm-tech

-- 

----------------------------------------------------------------------
    Chandra Seetharaman               | Be careful what you choose....
              - sekharan@xxxxxxxxxx   |      .......you may get it.
----------------------------------------------------------------------
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/